lizhimins commented on PR #5499: URL: https://github.com/apache/rocketmq-dashboard/pull/5499#issuecomment-6076050044
This one is already fixed on the trunk, in the opposite direction. #4884 (3b9e35fe4, 2026-09-24) added common/util/SubscriptionConsistency, so AliyunConverters:235 and TencentInstanceProvider:1076 now emit "consistent"/"inconsistent"/null and never leak true/false or 0/1 - its javadoc states that the studio vocabulary "is the only vocabulary the console understands" and that cloud providers must translate rather than leak. Your cited line numbers (AliyunConverters:223, TencentInstanceProvider:1036, RocketMQMetadataProvider:758) are from a pre-#4884 snapshot, and the test assertions you quote (.consistency(true), setConsistency(0L)) are SDK inputs, not outputs. Note also that your mapping is inverted relative to fromCode: Tencent 0 means consistent and 1 means inconsistent, while you put '1' in CONSISTENT_VALUES. Finally, consumerGroupDiagnostics.test.ts has 4 tests, not 36 - please re-verify against apache/rocketmq-studio before resubmitting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
