lizhimins commented on PR #5498:
URL:
https://github.com/apache/rocketmq-dashboard/pull/5498#issuecomment-6076049111
The contract analysis is accurate - the mock message is byte-identical to
AclService.invalidPagination() and to the sibling pageAclUsers mock, and the
only production
caller (acl.tsx:198) can never trip the new throw, so there is no UI
regression.
Blocking issue: aclServicePagination.test.ts:53 imports { aclRules } from
'../mock/acl' and
never uses it. web/tsconfig.app.json sets noUnusedLocals and includes "src",
and the build
script is `tsc -b && vite build`, so this turns the frontend build red
(eslint only warns).
Please drop that import, drop the no-op beforeEach(vi.restoreAllMocks), and
paste real
`tsc -b` / `eslint` output - the body currently only shows vitest.
Also worth stating explicitly that this is a mock/demo-mode alignment, not a
production fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
