lizhimins commented on PR #5433: URL: https://github.com/apache/rocketmq-dashboard/pull/5433#issuecomment-6075858095
The `deploy/deploy.sh` half of this is exactly right, and it is already on `rocketmq-studio`: we landed the same one-line change in #5759 (merged as `7e22f69c8`) before this PR was processed, so the branch now conflicts with trunk on that file. The `.claude/skills/deploy-rocketmq/SKILL.md` half is not superseded and is still worth having - the manual tar command documented there is missing `rmqctl`, `LICENSE`, `NOTICE` and the `deploy/.env` exclusion, and its `docker build ... server/` line contradicts the repository-root build context that `server/Dockerfile` requires. `deploy/` and the skill docs are maintainer-side tooling rather than a surface we take community changes to, so we are carrying that edit in a separate pull request with credit to you instead of rebasing this one. Closing as superseded. Thanks for tracing this to the actual root cause - the Dockerfile/build-context mismatch is the same one behind #5206. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
