The GitHub Actions job "CI" on rocketmq-dashboard.git/fix/settings-datasource-cache-scope has failed. Run started by GitHub user zjncs (triggered by zjncs).
Head commit for run: d5090b2595e7a4b5e04dabd387bb723335cae615 / zjncs <[email protected]> fix(settings): stop caching the parameterized data-source query The data-sources cache is documented (and tested by SettingsServiceCachingTest) as a cache of the full list, but the parameterised, paginated overload carried the same @Cacheable: its key is derived from caller-supplied search/type/page/pageSize, and CacheConfig backs it with a plain ConcurrentMapCacheManager with no TTL, size bound, or eviction — every distinct search term pinned a permanent PageResult in the heap. The paged endpoint is not admin-only, so any authenticated reader could grow the cache without bound. Drop the annotation on the parameterised overload; the documented full-list caching and write-path eviction are unchanged. Review adjustments (lizhimins): test methods renamed to end with "Test" per repo convention, trailing newlines restored, @Configuration/@Bean moved to imports, and the earlier credential-exposure framing dropped (DataSourceVO carries no credential fields; the unbounded-heap argument stands on its own). Rebased onto the rocketmq-studio integration branch. Verification on rocketmq-studio: SettingsServiceDataSourceCacheBoundTest + SettingsServiceCachingTest 3/3 green (docker maven); reverting only the SettingsService change makes the parameterised test fail with 50 pinned entries. Report URL: https://github.com/apache/rocketmq-dashboard/actions/runs/37898428192 With regards, GitHub Actions via GitBox
