lizhimins commented on PR #5299:
URL:
https://github.com/apache/rocketmq-dashboard/pull/5299#issuecomment-6076045670
- The round-trip bug is real: `Math.round((cfg.maxMessageSize ?? 4194304) /
1048576)` at `:708` is not invertible against `maxMessageSizeMB * 1048576` at
`:727`, so a no-op save rewrites a non-MiB-aligned broker value.
- Please add tests: with `config.maxMessageSize = 5000000`, an untouched
save must resend `5000000`, and editing the field to 6 must send `6291456`. The
existing fixtures all use `4 * 1024 * 1024`, so reverting your change keeps all
30 tests green.
- The `untouched` heuristic cannot tell "not edited" from "edited to exactly
the rounded display value" - in that case the user's edit is silently dropped.
`configForm.isFieldTouched('maxMessageSizeMB')` would close the hole.
- `Tests 29 passed` does not match the file (30 `it()`); please refresh the
log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
