zjncs commented on PR #5624: URL: https://github.com/apache/rocketmq-dashboard/pull/5624#issuecomment-6076793291
Hi @lizhimins, thanks for the review. All points are addressed; the PR is rebased onto rocketmq-studio c99b9ad5 and retargeted. Point by point: **Error propagation restored.** `writeTable` now returns an error (the first `fmt.Fprint` failure), `Rows` and `ConfigTable` propagate it directly, and `ToolCallSummary` keeps its explicit `if err := writeTable(...); err != nil` check — so the table half of the error checks in `cmd/catalog_renderers.go`, `cmd/config.go` and `cmd/explain.go` is live again, exactly as with the `tabwriter.Flush` calls before. Added `TestTableRenderersPropagateWriteErrors`, which drives all three renderers with an always-failing writer and fails if any of them swallows the error. **Trailing newlines restored** on `go.mod`, `output.go` and `output_test.go`; `gofmt -l .` is clean, so the `make fmt` step in ci.yml passes. **Import grouping fixed.** `golang.org/x/text/width` moved out of the stdlib group in `output.go` into the non-stdlib group alongside the internal and yaml imports, matching the convention in e.g. `internal/config/config.go` and `cmd/version.go`. **Ambiguous width documented.** `displayWidth` now states that East Asian Ambiguous runes (Greek, Cyrillic, `°`, ...) count as one cell, which is wrong on the many CJK terminals configured to render ambiguous-width runes two cells wide — the x/text width table cannot know the terminal's locale setting. Verification: `gofmt -l .` clean, `go test ./...` green. `TestRowsAlignsColumnsForWideRunes` still fails against the tabwriter implementation (fail-before confirmed), and the new propagation test fails if `writeTable` drops the `fmt.Fprint` error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
