The GitHub Actions job "CI" on rocketmq-dashboard.git/fix/table-cjk-alignment 
has failed.
Run started by GitHub user zjncs (triggered by zjncs).

Head commit for run:
c532dfaa8d9f145233723da5d8491b7bcaab3c7e / zjncs <[email protected]>
fix(rmqctl): pad tables to terminal display width

All three table renderers padded columns by rune count via
text/tabwriter, but terminals render CJK ideographs (common in topic
and consumer-group names) as two cells - every column after a CJK cell
shifted, breaking the alignment of topic list, group list and the other
table commands. Render through a shared writeTable helper that pads to
display width using the golang.org/x/text width table (already in the
module graph), counting East Asian Wide and Fullwidth runes as two
cells.

Closes #5623

Signed-off-by: zjncs <[email protected]>

Review adjustments (lizhimins):
- writeTable now returns an error and Rows/ConfigTable propagate it, and
  ToolCallSummary keeps its explicit error check, so the table half of
  the error checks in cmd/catalog_renderers.go, cmd/config.go and
  cmd/explain.go is live again; added TestTableRenderersPropagateWriteErrors
  to guard the propagation.
- Moved golang.org/x/text/width out of the stdlib import group in
  output.go into the non-stdlib group, matching the repo convention.
- Documented on displayWidth that East Asian Ambiguous runes count as
  one cell, which is wrong on the many CJK terminals configured to
  render ambiguous-width runes two cells wide.
- Restored the trailing newlines on go.mod, output.go and output_test.go;
  gofmt -l . is clean.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/37901254179

With regards,
GitHub Actions via GitBox

Reply via email to