The GitHub Actions job "CI" on rocketmq-dashboard.git/fix/search-like-escapes 
has failed.
Run started by GitHub user unbridled-41 (triggered by unbridled-41).

Head commit for run:
8ab86d71f834928734fa892061ff0972f38c2e39 / unbridled-41 
<[email protected]>
fix(search): escape the remaining LIKE sites through LikePatterns

The review of this PR found five paths still binding user text straight into a
MyBatis-Plus LIKE pattern:

- RocketMQMetadataProvider topic and group name search (four call sites);
- MybatisPlusInstanceRepository.search and findByTypeAndSearch (name, endpoint
  and remark);
- MybatisPlusAlertRepository rule name and metric search;
- MybatisPlusCloudCredentialRepository name search;
- the data-source type spliced into MybatisPlusSettingsRepository's CONCAT
  pattern, where the fragment's own wildcards sit next to the caller's value.

Route all of them through LikePatterns.escape, and add a regression test per
path asserting the bound parameter. The AuthService username search gets the
same treatment through AuthServiceDatabaseTest, mirroring the audit repository
test.

Also rename the LikePatternsTest methods to the Test suffix the rest of
common/util uses, and drop the AiTimelineRepositoryTest javadoc that still
claims the project has no shared escape helper.

Tested: full server suite -> 3339 tests, 0 failures; the 18 errors are the
MySQL-backed integration tests, which fail identically on the base commit
without a live database. Each new test fails when its path is reverted to the
unescaped term. Checkstyle clean.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/37945683198

With regards,
GitHub Actions via GitBox

Reply via email to