The GitHub Actions job "CI" on 
rocketmq-dashboard.git/fix/brokercluster-node-version has failed.
Run started by GitHub user unbridled-41 (triggered by unbridled-41).

Head commit for run:
f5768370b6125c3151a87d2dff9b820c0431c182 / unbridled-41 
<[email protected]>
fix(studio): stop showing the cluster version as every nameserver's and proxy's 
version

mapClusters wrote the cluster-level value into the per-node rows:

    nameServers.push({ ..., version: cluster.version, ... });
    proxies.push({ ..., version: cluster.version, ... });

but neither NameServerVO nor ProxyVO carries a version - NameServerInfo is
{addr, status} and ProxyInfo is {addr, status, connections, grpcPort,
remotingPort} in docs/api-spec.md and in web/src/api/cluster.ts - and the 
cluster
version itself is not set on the discovery path either
(RocketMQClusterProvider.buildClusterVO lists name/type/status/brokers/proxies/
nameServers/tpsHistory/counts only), so the column showed the mock's cluster
version for every node in demo mode and a blank cell otherwise. Both tabs also
exported that value as a `Version` CSV column.

Drop the field, the two columns and the two CSV entries, exactly as the
already-accepted removal of the fabricated NameServer Connections column did
(#5647/6c0e983d). The Broker tab keeps its own Version column, which comes from
BrokerVO.version.

Tests (web/): npx vitest run src/pages/studio/__tests__/BrokerCluster.test.tsx
-> Tests 17 passed.
- new case "does not render a Version column for nameservers or proxies" fails
  before this change (`expected document not to contain element, found <th`) and
  passes after it; it also asserts the broker tab still has one.
- npx eslint reports no errors; npx tsc -b passes.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/37981607003

With regards,
GitHub Actions via GitBox

Reply via email to