The GitHub Actions job "CI" on 
rocketmq-dashboard.git/fix/auth-audit-columns-utc has failed.
Run started by GitHub user unbridled-41 (triggered by unbridled-41).

Head commit for run:
4ed134736f69043a1623b8dd1c3d535e3167b4a8 / unbridled-41 
<[email protected]>
fix(auth): stamp the user and session audit columns in UTC

rmq_studio_user.gmt_create/gmt_modified and rmq_studio_session.gmt_create
default to the database session's CURRENT_TIMESTAMP when the insert omits
them, and AuthService omitted them: only the fields it sets explicitly
(password_changed_at, last_seen_at, expires_at) come from its UTC clock.
The columns are therefore filled with the wall clock of wherever MySQL
runs, while the Studio user and session APIs serialize every zone-less
timestamp as UTC and the console parses them as such
(UserManagement.tsx: "Studio user and session APIs serialize UTC
LocalDateTime values without an offset, so the timestamps have to be
parsed as UTC"). On the deployment the repository documents
(deploy/docker-compose.yml sets TZ and serverTimezone to Asia/Shanghai)
the Users page, the session drawer and both CSV exports therefore show a
creation time eight hours in the future, and one row prints "Created
18:00" next to "Password changed 10:00" for the same instant.

Stamp gmt_create/gmt_modified from the service's UTC clock on both insert
paths, and keep gmt_modified on the password-change update (which would
otherwise fall back to ON UPDATE CURRENT_TIMESTAMP) in the same zone.

Tests (server/): mvn -o -B -ntp test 
-Dtest='org.apache.rocketmq.studio.auth.*Test'
- new AuthServiceDatabaseTest cases 
createdUserCarriesTheUtcAuditInstantsTheApiSerializesTest,
  createdSessionCarriesTheUtcAuditInstantsTheApiSerializesTest and
  passwordChangeStampsTheUtcModifiedInstantTest fail before this change
  (gmtCreate/gmtModified null, gmt_modified absent from the SET clause)
  and pass after it.
- 155 auth tests pass; mvn -o -B -ntp checkstyle:check passes.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/37959764821

With regards,
GitHub Actions via GitBox

Reply via email to