unbridled-41 opened a new pull request, #5954:
URL: https://github.com/apache/rocketmq-dashboard/pull/5954
### Which Issue(s) This PR Fixes
Fixes #5953
### Problem / Evidence
Both tabs read the payload `handleModalTabChange` fetches, but only one
renders its state:
```tsx
// before: the consumer tab
<Table dataSource={traceData?.consumerStatus?.map((c, i) => ({ ...c, _key: i
})) || []} ... />
```
```
MessagePageAsyncState: reports a failed trace request on the verify tab
instead of an empty consumer table
TestingLibraryElementError: Unable to find an element with the text: Message
query provider is not configured
```
So a failed (or in-flight) trace request shows an empty consumer table,
which reads as "no consumer group consumed this message" - the opposite
conclusion - while the error is only visible on the Trace tab. #4910 added the
fetch for this tab without its request state.
### Root cause / Fix
One payload, one shared state, two panes - and only one pane rendered it.
Render the same loading text and warning alert on the Verify pane, and keep the
table for the loaded case.
### Priority and scoring
**PRIORITY 50** — impact 20/40 (the verification view states a false
negative for a failed request), blast radius 10/20 (one pane, in the modal
operators use for delivery checks), reproducibility 18/20 (deterministic,
pinned by the new test), maintenance value 2/20.
**FIX_CONFIDENCE 90** — the sibling pane's markup is the reference.
### Tests
`cd web && npx vitest run
src/pages/instance/__tests__/MessagePageAsyncState.test.tsx
src/pages/instance/__tests__/MessagePage.test.tsx` -> `Tests 49 passed`.
| Test | Before | After |
|---|---|---|
| `reports a failed trace request on the verify tab instead of an empty
consumer table` | FAIL (nothing rendered in the pane) | PASS |
| the existing trace-state and lazy-load cases | PASS | PASS |
`npx eslint` reports no errors; `npx tsc -b` passes.
### Risk
The pane shows a loading text where it used to show an empty table during
the fetch; the loaded case is unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
