The GitHub Actions job "CI" on rocketmq-dashboard.git/fix/proxy-consumer-union 
has failed.
Run started by GitHub user unbridled-41 (triggered by unbridled-41).

Head commit for run:
d55dd50ae668aebb388a5838ea91c83bd9c3758e / unbridled-41 
<[email protected]>
fix(group): union a proxy-connected group's clients across every proxy

ProxyConsumerResolver.resolveConsumerConnectionStatus asked each discovered 
proxy
in turn and returned as soon as one answered with a connection:

    if (result.connection() != null) {
        return ConsumerConnectionResolution.available(result.connection());
    }

Each proxy knows only the clients connected to it, so a gRPC group whose members
are spread over several proxies was reported with one proxy's connection set,
subscription table and channel list as the whole inventory. The consumers are 
the
group list (`instances`, `onlineInstances`), the group detail read and the AI
group-detail verdict, which reasons on that subset. The sibling client scan in 
the
same package already unions every proxy
(RocketMQClientProvider.findConsumerConnections), and its test asserts that a 
group
with clients on two proxies yields both.

Ask every proxy, merge what they answer (connections deduped by client id and
address, subscription tables unioned, the group-level model/consume-type taken 
from
the first non-null), and keep the existing offline-vs-unavailable accounting:
"no proxy knows this group" stays a known-offline answer.

Tests (server/): mvn -o -B -ntp test -Dtest='ProxyConsumerResolverTest' ->
Tests run: 7, Failures: 0, Errors: 0.
- new resolveConsumerConnectionStatusShouldUnionClientsFromEveryProxyTest fails
  before this change (only the first proxy's client and topic are present) and
  passes after it.
- mvn -o -B -ntp test 
-Dtest='RocketMQMetadataProviderTest,RocketMQClientProviderTest'
  -> Tests run: 91, Failures: 0, Errors: 0; checkstyle passes.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/37984874353

With regards,
GitHub Actions via GitBox

Reply via email to