Loyal-Young opened a new pull request, #5785:
URL: https://github.com/apache/rocketmq-dashboard/pull/5785

   ### Which Issue(s) This PR Fixes
   
   - Fixes #5780
   
   ### Brief Description
   
   Apply the timeline snapshot's existing conversation ownership check to 
transcript rows, rendered bubbles, the last sequence and the load-more cursor. 
Incremental reads now require a snapshot belonging to the conversation on 
screen. A pending or failed navigation to another conversation can no longer 
expose the previous transcript or append new events using its cursor.
   
   A failed refresh of the same conversation retains its last successful 
transcript.
   
   ### How Did You Test This Change?
   
   - Before the fix, the two new cross-conversation regressions fail: old rows 
remain visible, and load-more makes an extra request using the old cursor.
   - `cd web; node node_modules/vitest/vitest.mjs run 
src/pages/ai/hooks/useConversationTimeline.test.ts --pool=threads 
--maxWorkers=1 --reporter=dot` — 14 tests passed, including same-conversation 
refresh and the existing overlapping-load cases.
   - `cd web; node node_modules/typescript/bin/tsc -p tsconfig.app.json 
--noEmit --pretty false` — passed.
   - `cd web; node node_modules/eslint/bin/eslint.js 
src/pages/ai/hooks/useConversationTimeline.ts 
src/pages/ai/hooks/useConversationTimeline.test.ts` — passed.
   - `git diff --check` — passed.
   - Tested against `rocketmq-studio@c99b9ad50b79467546997e51f3401d57ceebea5f`. 
Full application build and backend tests were not rerun for this hook-only 
change.
   
   ### Checklist
   
   - [x] One coherent change
   - [x] Conventional commit title
   - [x] Regression tests
   - No new UI text, source files, dependencies or backend changes.
   
   ### AI Assistance
   
   AI assistance was used to trace conversation ownership and pagination, draft 
deferred regressions, implement the guard and run local checks. The new 
regressions were first run against the original implementation.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to