The GitHub Actions job "CI" on rocketmq-dashboard.git/rocketmq-studio has 
failed.
Run started by GitHub user lizhimins (triggered by lizhimins).

Head commit for run:
12b63f34778007f53f52d3efdb8edb95d33818c8 / 烤化の初雪 <[email protected]>
fix(ai): correct three run-lifecycle defects around stopping and attaching 
(#5440)

Three defects in the AI run lifecycle, plus the test that was racing them.

- The composer lost a draft when Enter arrived while a run was stopping: 
`canSend` keyed off
  `!generating`, and `generating` is already false once a stop was requested, 
so the message went into
  a run that was ending. (#5425)
- `AiRunService.stop` read the single boolean from `registry.stop()` as "this 
process does not own the
  run" and then wrote a terminal state for a run that was still live. (#5440)
- `useActiveRunAttach` keyed its anti-hot-loop ref on the run id alone, so a 
run that left the
  admission window and came back with the same id attached to a cleanly 
finished empty stream instead
  of an error state. The ref now carries id + status. (#5446)
- `AiRunServiceTest.stopShouldAbortALiveRunAndLeaveItStoppedWithUserStopTest` 
asserted without
  waiting for the worker, which made it flaky - this is the failure that 
reddened an unrelated PR's
  `Backend Tests` run today. (#5450)

`AiRunServiceTest` 23 tests green with the dev profile, 0 checkstyle violations;
`Composer.test.tsx` + `useActiveRunAttach.test.ts` 21 tests green; prettier 
clean.

Folded in #5425, #5446 and #5450.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/37905155778

With regards,
GitHub Actions via GitBox

Reply via email to