chennaji9 opened a new pull request, #11346:
URL: https://github.com/apache/rocketmq/pull/11346

   <!-- Please make sure the target branch is right. In most case, the target 
branch should be `develop`. -->
   
   ### Which Issue(s) This PR Fixes
   
   Fixes #11337
   
   ### Brief Description
   
   Adds `ControllerClosureTest`, direct coverage of how every JRaft-driven 
controller request completes (currently untested):
   
   - `run(Status.OK)` completes the future with the configured response code, 
body and remark — and leaves body/remark unset when the `ControllerResult` 
carries none;
   - `run(Status<error>)` maps any JRaft failure to 
`ResponseCode.CONTROLLER_JRAFT_INTERNAL_ERROR` with the status message;
   - `taskWithThisClosure()` returns the same cached `Task` instance on 
repeated calls, bound to this closure as `done`, carrying the encoded request 
as `data`.
   
   Test-only change; no production code touched.
   
   ### How Did You Test This Change?
   
   `mvn -pl controller -Dtest=ControllerClosureTest 
-Dsurefire.failIfNoSpecifiedTests=false test` (JDK 11, PR base commit): `Tests 
run: 4, Failures: 0, Errors: 0`.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to