The GitHub Actions job "CI" on 
rocketmq-dashboard.git/fix/cloud-import-audit-resource has failed.
Run started by GitHub user unbridled-41 (triggered by unbridled-41).

Head commit for run:
08c6b9b066c47d997d23be6a25fa89999d915697 / unbridled-41 
<[email protected]>
fix(instance): attribute a cloud-import audit to the credential it read

The import recorded its audit row as an instance id:

    recordAudit("IMPORT_CLOUD_INSTANCES", "INSTANCE", 
String.valueOf(credentialId), ...)

but the number is a cloud-credential primary key. The audit timeline is a strict
(resource_type, resource_name) lookup (MybatisPlusAuditRepository.applyFilters, 
the
drawer passes exactly those two), so:

- the credential's own history - the place an auditor looks for "what was done 
with
  this credential" - showed no import at all, while
- the import appeared on whatever *instance* happens to carry that numeric id, 
with
  the row labelled "Instance" by the presentation mapping.

Every other audit of this service uses a real entity id under its own type
(CREATE/UPDATE/DELETE_INSTANCE -> INSTANCE, the credential service ->
CLOUD_CREDENTIAL), and the per-instance CREATE_INSTANCE audits already cover the
instances an import creates.

Tests (server/): mvn -o -B -ntp test -Dtest='InstanceServiceTest' -> Tests run: 
98,
Failures: 0, Errors: 0. The two existing assertions that pinned the wrong tuple
(importCloudInstancesShouldAuditAFullyFailedImportAsFailedTest and
importCloudInstancesShouldContinueAfterUnexpectedRegionFailureTest) now require
CLOUD_CREDENTIAL and fail before this change.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/37991051966

With regards,
GitHub Actions via GitBox

Reply via email to