unbridled-41 opened a new pull request, #5997: URL: https://github.com/apache/rocketmq-dashboard/pull/5997
### Which Issue(s) This PR Fixes Fixes #5996 ### Problem / Evidence `web/src/pages/instance/acl.tsx` declared eleven `sorter`s on tables fed by `listAclRules`/`pageAclUsers` (server pagination, server totals): ``` AclPage: does not offer in-memory sorters on the paged rule and user tables AssertionError: expected <th aria-label="主体" ...> (has-sorters class present) ``` ### Root cause / Fix Leftovers from when the inventories were fully client-side. Remove the eleven sorters; the endpoints have no sort parameter, and the same removal is in flight for the DLQ/message tables (#5335/#5295). ### Priority and scoring **PRIORITY 55** - impact 18/40 (a sorted-looking table that is only sorted within a page), blast radius 12/20 (two ACL tables), reproducibility 18/20 (pinned by the new test), maintenance value 7/20. **FIX_CONFIDENCE 80**. ### Tests `cd web && npx vitest run src/pages/instance/__tests__/AclPage.test.tsx` -> `Tests 27 passed`; the new case fails before the change and passes after it; `npx eslint` and `npx tsc -b` pass. ### Risk Column headers lose their sort affordance; sorting was never correct across pages. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
