The GitHub Actions job "CI" on rocketmq-dashboard.git/fix/topic-create-response has failed. Run started by GitHub user unbridled-41 (triggered by unbridled-41).
Head commit for run: e46d88c88101ca01c21a2ea5df6f2eae70f6f55e / unbridled-41 <[email protected]> fix(topic): answer a topic create with the stored perm, cluster and type The create path applies defaults the request may omit - `perm RW` when none is given, the resolved cluster, `type NORMAL` - but the response was still the request object with only id/queues back-filled, so a caller received `perm: null`, `clusterId: null` and (when the type was omitted) `type: null` for a topic the very next read reports as RW, cluster-bound and NORMAL. The update path already back-fills the persisted remark for exactly this reason ("so a clear or an omitted remark cannot be mistaken for a value the update did not write") but not the permission, cluster or type. Project the stored columns onto the response for both paths, so the create/update answer is the stored resource rather than the request. Tests (server/): mvn -o -B -ntp test -Dtest='RocketMQAdminClientImplTest' -> Tests run: 81, Failures: 0, Errors: 0; the new case fails before this change (perm null) and passes after it; checkstyle passes. Report URL: https://github.com/apache/rocketmq-dashboard/actions/runs/37998423246 With regards, GitHub Actions via GitBox
