The GitHub Actions job "CI" on 
rocketmq-dashboard.git/fix/silence-instance-bounds has failed.
Run started by GitHub user unbridled-41 (triggered by unbridled-41).

Head commit for run:
51885810b548ed960e81fa6322ed39c99f1f14f4 / unbridled-41 
<[email protected]>
fix(alert): bound a silence's instanceId to its column

`AlertSilenceService.create` bounds the reason to its 512-character column (and 
the
labels), then writes `trimToNull(request.getInstanceId())` into `instance_id
VARCHAR(128)` with no check. An instanceId longer than that reached the 
database, the
rejection arrived as a DataIntegrityViolationException with no handler, and the 
API
answered 500 - so an operator setting up a maintenance window saw a failure 
with no
usable reason and, worse, could believe the window existed when it did not.

Bound the field with the same code-point rule the reason already uses 
(TextBounds),
failing with 400 before any write.

Tests (server/): mvn -o -B -ntp test 
-Dtest='AlertSilenceServiceTest,AlertSilenceControllerTest'
-> Tests run: 15, Failures: 0, Errors: 0; the new case fails before the change 
and
passes after it, asserting no repository write; checkstyle passes.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/37998370157

With regards,
GitHub Actions via GitBox

Reply via email to