pilichoumao commented on PR #5116: URL: https://github.com/apache/rocketmq-dashboard/pull/5116#issuecomment-6093275901
Rebased onto `rocketmq-studio@7e7aa344`. The only conflict was the `catalog_gen.go` digest again — resolved by taking upstream and re-running `make catalog-generate`; no tool code changed, still 7 files **+321/−1**, head `67cfeb0f`. Local re-verification on the new base (`mvn -B -ntp clean verify -Dmaven.antrun.skip=true -Dspring.profiles.active=dev`, JDK 21): **3,399 tests, 0 failures, 3 skipped, 0 Checkstyle violations**. The single error is `ResourceOwnershipGuardTest#migrationConcurrentStartupIsIdempotentTest` (H2 `ConcurrentModificationException` during concurrent migration), which reproduces on pristine `7e7aa344` and is unrelated to this branch. `make catalog-verify`, `gofmt` and `go vet` are clean. CI attribution for this run, so the four red jobs are not misread. Compared against pristine trunk's own push run on the same commit [`7e7aa344`](https://github.com/apache/rocketmq-dashboard/actions/runs/37924783619): | Job | trunk push (7e7aa344) | this PR ([run](https://github.com/apache/rocketmq-dashboard/actions/runs/38019840264)) | | --- | --- | --- | | Backend Tests (Java 21) | ✅ | ✅ | | Backend Build (Java 21) | ❌ | ❌ | | Frontend Build (Node 20) | ❌ | ❌ | | Frontend Docker Build | ❌ | ❌ | | rmqctl Build (Go) | ❌ | ❌ | The Go job fails at the same step (`make test-race`) with the identical eight `payload changed` assertions in `TestMessageQueryCompletenessWarningTest` (`catalog_renderers_test.go:99`, integers rendered as strings) — a file this PR does not touch. Flagging one correction: that gate was green for this PR's previous run (36977848140, 10-02) and turned red on trunk during the 10-09 merge wave, so my earlier "three license gates" note undercounts by one. The CI delta attributable to this change is still zero. Also superseding an outdated line in the PR body: its "CI Status" section still describes the old Actions `startup_failure` policy problem; real runs exist now, so the table above is the current picture. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
