lizhimins commented on PR #5772: URL: https://github.com/apache/rocketmq-dashboard/pull/5772#issuecomment-6094441674
The consistency argument holds — the queue-stats view on the same screen, `orderedBrokerAddrs` (line 541) and the group/progress sorts (lines 599, 718) all order their output, and the route table was the one that did not. `queueDatas` is the only source of route rows and brokerName is unique per topic, so no tie-break is needed and nothing else in the family is missed; the neighbouring `getTopicRoutesShouldExposeBrokerTopologyDetails` uses a single QueueData, so it is unaffected. Only outstanding item: rename the test to `getTopicRoutesShouldOrderRoutesByBrokerNameTest` (repo convention). Please also soften "rebuilt from a hash table per snapshot, so that order is not stable" — for an identical route the order is deterministic; the point is consistency with the stats table. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
