lizhimins commented on PR #5761: URL: https://github.com/apache/rocketmq-dashboard/pull/5761#issuecomment-6094440031
The re-read is the right fix and the test pins the interleaving precisely (consecutive `findById` stubbing, plus `runUpdates`/`inserted` both asserted empty, so dropping the re-read turns it red). One naming nit before merge: the repo convention is that Java test methods end with `Test` — please rename to `aStopThatLosesTheFinalisationRaceMustNotWriteASecondTerminalTest` (this file already follows it in 23 of 25 cases). Optionally drop the duplicated `runRepository.findById(runId)` at the end of the unowned branch, since the method's final return does the same re-read. We are taking this together with #5760 — they cover the two sides of the same corruption (worker `decide()` vs. the service's unowned path), not duplicates of each other. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
