Loyal-Young opened a new pull request, #6051:
URL: https://github.com/apache/rocketmq-dashboard/pull/6051

   ### Which Issue(s) This PR Fixes
   
   - Fixes #6047
   
   ### Brief Description
   
   When retention or cleanup removes the last audit page, clamp the resource 
timeline to the last valid page and re-query before committing the response. 
The drawer previously hid its pager together with the empty page, making 
remaining records unreachable.
   
   Preserves the existing request-version guard and resource/date filters. 
Total zero settles at page 1; a valid page continues to load normally.
   
   ### How Did You Test This Change?
   
   - On unmodified source with the final tests: 2 new failures, 5 existing 
tests pass. Both new cases observe a missing recovery request (totals 5 and 0).
   - `node node_modules/vitest/vitest.mjs run 
src/pages/ops/__tests__/ResourceOperationTimelineDrawer.test.tsx --pool=threads 
--maxWorkers=1 --reporter=dot`: 7 passed after the fix.
   - Existing cases cover normal page 2 navigation, date filtering/export, and 
a superseded resource request.
   - ESLint on both files, TypeScript app check (`--noEmit --composite false 
--incremental false`), and `git diff --check`: passed.
   - The new mock reset is scoped to the retention tests.
   
   ### Checklist
   
   - [x] One coherent change; Conventional Commit title.
   - [x] Regression tests added; new test names end in Test.
   - [x] No new UI strings, source files or API contracts.
   - [ ] Backend architecture tests not rerun locally (frontend-only change).
   
   ### CI baseline
   
   Tested on 29fe48abc. Its [frontend 
job](https://github.com/apache/rocketmq-dashboard/actions/runs/38023023425/job/114127943196)
 already fails the artifact license gate after build/tests, and its [backend 
build](https://github.com/apache/rocketmq-dashboard/actions/runs/38023023425/job/114127943241)
 already fails the binary license gate. These links describe the upstream 
baseline, not a green PR CI claim.
   
   ### AI assistance
   
   AI assistance was used to inspect the pagination path, implement the clamp 
and author the interaction tests. The diff and test results were reviewed in 
this contribution session.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to