lizhimins commented on PR #5771: URL: https://github.com/apache/rocketmq-dashboard/pull/5771#issuecomment-6094441140
Verified against today's `rocketmq-studio`: line 359 is still the only order-sensitive walk of `clusterAddrTable` in this file — the other two (lines 225 and 260) feed a `HashSet` and a `HashMap`, so they do not need the same treatment, and no existing assertion in `RocketMQDashboardProviderTest` pins a multi-cluster order, so nothing breaks. Two things before merge: (1) rename the test to end with `Test` per repo convention; (2) please soften the rationale — a `HashMap` iterates deterministically for an identical key set, so the overview does not actually reorder itself between polls; the real value is agreeing with the cluster list (`RealClusterProvider.java:133`). We plan to merge this together with #5770 so both views order the same way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
