Loyal-Young commented on PR #5787:
URL:
https://github.com/apache/rocketmq-dashboard/pull/5787#issuecomment-6094608788
Updated in f535fd4bc7259d21e77b02ed305f50ba181428a0. startRun now
distinguishes an abandoned request ('abandoned') from an owned failure (null).
The handoff drops the abandoned path without navigation or draft writes, and
manual-send restoration additionally checks its initiating location generation.
Added real AiPage/MemoryRouter regressions for manual send and home-page
handoff: both navigate to conversation 7 while creation is pending, type a new
draft there, and resolve creation as conversation 99. They assert the current
route and exact new draft survive and no stream starts. Both fail on the
previous PR head. An owned creation failure still restores its draft; the
existing positive handoff still sends once and strips state.
After: 24 tests pass across AiPage and useAiSend; changed-file ESLint, full
app TypeScript (noEmit, composite/incremental false), and diff checks pass. An
already submitted create request can still leave its server-side conversation
row; the fix only discards obsolete client effects. I am also documenting that
in #5781. AI assistance was used for implementation/tests, with diff and result
review in this session.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]