Loyal-Young opened a new pull request, #6060:
URL: https://github.com/apache/rocketmq-dashboard/pull/6060

   ### Which Issue(s) This PR Fixes
   
   - Fixes #6054
   
   ### Brief Description
   
   Cancel a pending metrics authentication dialog when its data source is no 
longer available to the selected instance. Pending sources are separate from 
the activated source key, so the existing activated-source fallback did not 
close this dialog.
   
   Use the existing cancellation path to restore a history replay's profile, 
range and custom query, and update the range ref before the instance-change 
query. Guard form submission against an unavailable source as well. Global 
sources remain usable across instances.
   
   ### How Did You Test This Change?
   
   - Two deferred instance-change regressions (picker and history entry) fail 
before the fix; the full MetricsExplorer suite passes afterward: 39 tests.
   - Verify that leaving a scoped source closes its credential form, restores 
the profile/range, and queries the default source with the restored metric and 
one-hour window.
   - A positive test authenticates a global source after changing instance and 
verifies its exact source key, credentials and new instance.
   - Disable Ant Design motion only in the new cancellation scenarios to test 
dialog state without exit-animation timing.
   - ESLint, full app TypeScript check (`--noEmit --composite false 
--incremental false`), and `git diff --check`: passed.
   
   ### Checklist
   
   - [x] One coherent change; Conventional Commit title.
   - [x] Regression tests added; new test names end in Test.
   - [x] No new UI strings or public API contracts.
   - [ ] Backend architecture tests not rerun locally (frontend-only change).
   
   ### CI baseline
   
   Tested on 29fe48abc. Its [frontend 
job](https://github.com/apache/rocketmq-dashboard/actions/runs/38023023425/job/114127943196)
 already fails the artifact license gate after build/tests; its [backend 
build](https://github.com/apache/rocketmq-dashboard/actions/runs/38023023425/job/114127943241)
 already fails the binary license gate. PR CI still needs to run independently.
   
   ### AI assistance
   
   AI assistance was used to trace authentication and history rollback, 
implement the scope check and write component regressions. The diff and test 
results were reviewed in this contribution session.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to