The GitHub Actions job "CI" on rocketmq-dashboard.git/fix-yaml-numbers-2 has 
failed.
Run started by GitHub user lizhimins (triggered by lizhimins).

Head commit for run:
9bf2475ff6d2464e76a4e2018da8e5685ed58dab / lizhimins <[email protected]>
fix(rmqctl): restore numeric types before YAML encoding

#6056 landed the regression test but not the fix: the commit that was supposed 
to
carry it had `output.go` reverted by a `git checkout --` after a mutation 
check, so
only `output_test.go` was pushed. Trunk therefore still quotes every number in
`-o yaml` output (`size: "3"`), and now fails both 
`TestYAMLRestoresJSONNumbersTest`
and the yaml subtests of `TestMessageQueryCompletenessWarningTest`.

The cause is #5262 decoding studio payloads with `json.Decoder.UseNumber()`:
`json.Number` is a string type, `encoding/json` marshals it as a bare literal 
but
yaml.v3 does not know it and quotes it. Restore the numeric types on the way 
into
the YAML encoder - integers become int64 so offsets past 2^53 stay exact, other
numbers become float64, everything else is passed through. The JSON path and the
table renderer are unchanged.

`make fmt` clean; `go test ./...` green across all seven rmqctl packages.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/38031020673

With regards,
GitHub Actions via GitBox

Reply via email to