zmuxuny commented on PR #5202: URL: https://github.com/apache/rocketmq-dashboard/pull/5202#issuecomment-6094735070
Thanks for verifying the RocketMQ 5.5.0 distinction. I kept the physical-ID correction unchanged and took the narrow-scope option from this review: the fixed path is reachable only for callers that already hold a physical offset ID. The UI-published `UNIQ_KEY` path is a separate public-contract defect tracked in https://github.com/apache/rocketmq-dashboard/issues/6061; this PR does not claim to fix it or choose new `MessageRecordVO.msgId` semantics. I reran the exact seven-class Maven aggregate on unchanged head `ec162a40181abaa39e8804373733efb31d121f68`: **165 tests passed**, including **65 RocketMQMessageProviderTest cases**, with zero failures/errors/skips. Fresh Surefire XML reports confirm those counts. Checkstyle has zero violations. The PR body now replaces the stale 64/162 values and clearly separates fresh focused verification from the historical full-CI and packaging limitations. No production/test code was changed for this review response. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
