Loyal-Young opened a new pull request, #6068: URL: https://github.com/apache/rocketmq-dashboard/pull/6068
### Which Issue(s) This PR Fixes - Fixes #6065 ### Brief Description Only delete an instance-list request's dedupe entry if it still points to that request. Mutation invalidation lets a fresh request replace an older one, but the old promise's unconditional cleanup could evict the replacement and cause concurrent callers to repeat discovery. ### How Did You Test This Change? - Before the fix: 2 failures and 13 passes in instanceService tests. - After the fix: all 15 pass. - Hold the post-mutation read pending, settle the older read with success or failure, and verify that a third caller joins the new read (two API calls total). - Check per-caller defensive copies and that a completed current read is removed. - Check that both callers see a current request failure and a subsequent call can retry. - ESLint, full app TypeScript check (`--noEmit --composite false --incremental false`), and `git diff --check`: passed. - This extends the already merged mutation invalidation in #4874 with a cleanup ordering it does not cover. ### Checklist - [x] One coherent fix; Conventional Commit title. - [x] Regression test names end in Test. - [x] No new UI strings or API contracts. - [ ] Backend architecture tests not rerun (frontend-only change). ### Verification scope Local tests used snapshot 29fe48abc. The intervening upstream changes through 5e4c39b do not change either touched file; the published commit preserves that newer upstream tree. PR CI remains the integration check. ### AI assistance AI assistance was used to trace the promise map, implement conditional cleanup, and author deferred-response regressions. The diff and test results were reviewed in this contribution session. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
