The GitHub Actions job "CI" on 
rocketmq-dashboard.git/fix/metrics-stored-auth-mode has failed.
Run started by GitHub user Frun1na (triggered by Frun1na).

Head commit for run:
a8b6142d79e0f7ac0c2200b09220352f000a0091 / Apulupie 
<[email protected]>
fix(metrics): accept the authentication modes a saved data source carries

fix(metrics): accept the authentication modes a saved data source carries

A data source saved from the console stores its authentication mode as "Basic 
Auth" / "Bearer Token";
SettingsService canonicalizes that to "basic auth" / "bearer token" (AUTH_BASIC 
/ AUTH_BEARER) and its
connection test accepts those values. The query path switched on the legacy 
studio.prometheus
vocabulary ("basic" / "bearer") only, so every authenticated data source fell 
into the default branch
and answered 503 "Unsupported Prometheus authentication mode: basic auth" for 
every query - while its
connection test kept passing and the Metrics Explorer, the dashboards and the 
bound-instance tool
query could never read it.

The configured mode is now resolved to the canonical token the switch uses, 
accepting both
vocabularies ("Basic Auth", "basic auth", "basic" and the bearer equivalents). 
An unrecognized mode
is still rejected with the message naming what was configured, and "none" still 
sends no credentials.

MultiBackendMetricsSourceTest: 17 tests green, 0 checkstyle violations. The 
three new cases fail on
the unfixed code with the 503 the report describes.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/38039460047

With regards,
GitHub Actions via GitBox

Reply via email to