tju-yxq opened a new pull request, #6159:
URL: https://github.com/apache/rocketmq-dashboard/pull/6159
> Resubmission of #5414 — the original PR and its linked issue were closed
by the repo's 7-day stale bot while awaiting review, not because the change was
rejected. The fix is rebased unchanged onto the current `rocketmq-studio` head
(5e4c39b0) and the linked issue is still reproducible on trunk.
> The original linked issue met the same stale fate and could not be
reopened, so this PR fixes a fresh report of the same problem (see the linked
issue).
### Which Issue(s) This PR Fixes
- Fixes #6158
### Brief Description
`loadInstances`' catch now clears the rows and the selection alongside the
existing toast when the latest request fails, mirroring the sibling pages'
handling of the identical failure (`BrokerCluster` clears its data in the
catch; `AlertRuleAssetList` shows a persistent error). The request-id
stale-response guard is untouched — this only closes the failure path of the
latest request, which previously left the previous query's rows listed under
the new filter.
### How Did You Test This Change?
```
cd web && npm test -- InstancePage.test.tsx --run
Test Files 1 passed (1)
Tests 28 passed (28)
```
One new test loads the unfiltered list successfully, switches the type
filter to Direct 模式 with the follow-up query rejecting, and asserts both
previous rows leave the table. The 27 existing tests — including the
stale-response guard ("ignores an older search response that finishes after the
latest request") — pass unchanged.
```
cd web && npm run lint
✖ 10 problems (0 errors, 10 warnings) # the trunk baseline
```
```
cd web && npx tsc -b --force
(no output — exit 0)
```
### Checklist
- [x] One coherent change; unrelated modifications are not bundled in
- [x] Commit subject follows Conventional Commits
- [x] Tests added or updated for non-trivial changes, test methods named
`...Test`
- [x] New UI text has both Chinese and English entries under `web/src/i18n/`
(no new UI text)
- [x] Architecture constraints stay green (`mvn test` runs the ArchUnit
checks) (no Java changes)
- [x] New source files carry the ASF license header (no new source files)
- [ ] Documentation touched where behaviour changed (failure-path correction
only)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
