tju-yxq opened a new pull request, #6165:
URL: https://github.com/apache/rocketmq-dashboard/pull/6165
> Resubmission of #5159 — the original PR and its linked issue were closed
by the repo's 7-day stale bot while awaiting review, not because the change was
rejected. The fix is rebased unchanged onto the current `rocketmq-studio` head
(5e4c39b0) and the linked issue is still reproducible on trunk.
### Which Issue(s) This PR Fixes
- Fixes #3564
### Brief Description
Re-submits the previously reviewed change (supersedes #4477, which was
auto-closed by the stale bot after 7 days without activity) rebased onto
current `master` at `0228dad5`. The instance inventory gains a vendor filter
(Apache / Aliyun / Tencent) and server-side pagination via a new
`listInstancesPage` API, so large inventories no longer load in one unfiltered
list. Conflicts with the recent `master` changes were resolved by keeping the
vendor-aware subtitle text, adopting `pointerEventsCheck: 0` in the tests, and
porting the two cloud-vendor tests to the paginated mock.
### How Did You Test This Change?
Run on the rebased branch (`504c850d`):
```
cd server && mvn -B -ntp
'-Dtest=InstanceServiceTest,MybatisPlusInstanceRepositoryTest,InstanceControllerTest'
test
InstanceControllerTest: 12, InstanceServiceTest: 91,
MybatisPlusInstanceRepositoryTest: 20
Tests run: 123, Failures: 0, Errors: 0, Skipped: 0 — BUILD SUCCESS
cd web && npm test -- InstancePage --run
Test Files 1 passed (1)
Tests 27 passed (27)
cd web && npm run lint
0 errors (11 pre-existing warnings in unrelated files)
```
The server run includes the `InstanceServiceTest` cases added by #4713
(legacy null vendor), which pass together with the vendor filter changes.
### Checklist
- [x] One coherent change; unrelated modifications are not bundled in
- [x] Commit subject follows Conventional Commits
- [x] Tests added or updated for non-trivial changes, test methods named
`...Test`
- [x] New UI text has both Chinese and English entries under `web/src/i18n/`
- [x] Architecture constraints stay green (`mvn test` runs the ArchUnit
checks)
- [x] New source files carry the ASF license header
- [ ] Documentation touched where behaviour changed (README / `docs/` /
in-app help)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
