zmuxuny commented on PR #5255: URL: https://github.com/apache/rocketmq-dashboard/pull/5255#issuecomment-6096850463
Thanks for the detailed review. Addressed all three requests in fa3641209c4bffccc515533ecddf61c75548d2b5. 1. Publication and destruction now share a separate short lifecycle monitor, never held across start(). Destruction marks the resolver closed without waiting for startup; a late startup result is disposed rather than published. Shutdown is idempotent and later queries are rejected. 2. Failed initialization backs off for one second across requests. Tests use a controlled monotonic clock and verify both suppression of repeated initialization and recovery after the interval. 3. Removed clientStarted; the non-null published client is the started-state invariant. The three new regressions failed against the old production code. Final focused matrix: 102/102 passed, Checkstyle zero violations, diff check passed, and an independent review completed. The published tree matches the tested tree. Current-head CI completed: Backend Tests passed 3439/3439; Frontend Build, Frontend Docker Build, and rmqctl Build passed. Backend Build remains blocked by the binary-license gate (missing complete upstream LICENSE/COPYING and original Spring Boot loader legal resources), so overall CI is not green: https://github.com/apache/rocketmq-dashboard/actions/runs/38046754975 . Ready for re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
