zmuxuny opened a new pull request, #6190:
URL: https://github.com/apache/rocketmq-dashboard/pull/6190

   ### Which Issue(s) This PR Fixes
   
   Fixes #6185
   
   ### Brief Description
   
   Give the alert page content a stable domain key so the rule editor, metric 
requests, test results and mutation state belong to one alert domain. This 
replaces the partial domain-change reset that cleared only list state.
   
   Previously, navigating Back from cluster alerts to business alerts retained 
the cluster rule's editor. Submitting that editor called `updateAlertRule` with 
the cluster rule ID and the BUSINESS domain. A pending cluster test could also 
populate a subsequently opened business editor. This change isolates the UI 
state; it does not cancel server requests that have already been sent.
   
   Navigation within the same domain keeps unsaved edits. Changing domains 
closes the old editor, and a newly opened business editor submits its own rule 
with BUSINESS routing.
   
   ### Verification
   
   - On base `5e4c39b053c35a5598cc79ff331b8a54e649d7b1`, the new route-history 
and late-test regressions failed; the same-domain navigation control passed (2 
failed, 1 passed).
   - A separate baseline diagnostic confirmed the erroneous service invocation: 
a cluster rule payload was sent with the BUSINESS argument. This does not claim 
that the server accepted it.
   - Regression coverage includes Browser Back/Forward, new-domain submission 
routing, preserving an unsaved name on same-domain query navigation, 
Cancel/reopen, and a previous domain's late test response.
   - `npm test -- src/pages/ops/__tests__/AlertsPage.test.tsx --maxWorkers=1`: 
33 passed.
   - `npm run lint`: 0 errors, 10 existing warnings.
   - `npm run build`: passed, including the production artifact license check.
   - `git diff --check`: passed.
   
   The complete frontend suite and backend tests were not run for this 
frontend-only change. AI assistance was used; the regressions were reproduced 
before changing production code, and a separate reviewer independently 
reproduced the red/green cases and reviewed the final diff.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to