The GitHub Actions job "License checker" on rocketmq.git/fix/batch-ack-unique-key-overwrite has failed. Run started by GitHub user zjncs (triggered by zjncs).
Head commit for run: a955e7d2dbf57a049ab8bb81350a63e68debd1e9 / zjncs <[email protected]> fix(broker): stop overwriting batch ack uniq key with single ack key in appendAck appendAck set PROPERTY_UNIQ_CLIENT_MESSAGE_ID_KEYIDX correctly per ack type (genBatchAckUniqueId for BatchAckMsg, genAckUniqueId otherwise), but a later unconditional put overwrote it with genAckUniqueId for every ack. Batch acks therefore landed on the revive topic with a bogus uniq key: the offset segment was the -1 sentinel the batch path assigns and the tag segment was ACK instead of BATCH_ACK, so every batch ack of a pop produced the same non-unique client id and tracing by uniq key was impossible. The buffered path in PopBufferMergeService already writes the batch uniq key without overwriting it. Drop the stray put so the per-type key set just above survives. Report URL: https://github.com/apache/rocketmq/actions/runs/34573334161 With regards, GitHub Actions via GitBox
