RockteMQ-AI commented on issue #11340: URL: https://github.com/apache/rocketmq/issues/11340#issuecomment-6110385326
**Issue Evaluation** Category: `type/enhancement` | Status: **Evaluated** **Feasibility:** Feasible **Scope:** `filter` module — `FilterFactory` test coverage **Compatibility:** No breaking changes Adding tests for duplicate-registration rejection and unregister semantics is straightforward. These are important guard-rail tests — if the `IllegalArgumentException` guard regressed to a silent overwrite, a custom filter SPI could silently replace another, causing subscription routing errors at runtime. **Assessment:** Valid enhancement. The suggested tests cover the registration guard and unregister contract, both of which currently lack direct coverage. --- *Automated evaluation by RocketMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
