lizhimins commented on PR #5819: URL: https://github.com/apache/rocketmq-dashboard/pull/5819#issuecomment-6120379652
Thanks — this is merged, as part of [`085e1fedf`](https://github.com/apache/rocketmq-dashboard/commit/085e1fedfcf60ccbf285bf12e7143c307d0b228c) on `rocketmq-studio`. Your change went in together with #5818 — all yours, all in the same area — so we folded them into a single commit instead of landing several near-identical entries for the same subsystem. Nothing was dropped. The commit message calls this one out explicitly: > #5819 `AiRunService.java:209` prepared an agent workspace for every engine, so a pure `http` completion turn — the engine `LlmConfigService.java:346-352` also falls back to for any unknown value — was failed with a 500 by a `RuntimeException` out of `prepare()` (`:210-220`) or collected a "RocketMQ tools unavailable" notice on every turn → `workspace.prepare(...)` is skipped when `AiRunExecutor.isHttpEngine(engine)` (a package-private static at `AiRunExecutor.java:630-633`, reachable from `AiRunService` in the same package, and already null/blank-safe), the notice condition becomes `preparation == null && !httpEngine`, and the `null` preparation handed to `RunContext` at `:228` is never read on that path because `AiRunExecutor.java:361-364` branches to `streamHttp` before anything touches `options()`; `engine` is already in scope from `:181`. Closing as folded, not rejected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
