lizhimins commented on PR #6323: URL: https://github.com/apache/rocketmq-dashboard/pull/6323#issuecomment-6120402804
Thanks — this is merged, as part of [`975a82e55`](https://github.com/apache/rocketmq-dashboard/commit/975a82e557aada209d52fa0bb0774232cb336079) on `rocketmq-studio`. Your change went in together with #6279 — all yours, all in the same area — so we folded them into a single commit instead of landing several near-identical entries for the same subsystem. Nothing was dropped. The commit message calls this one out explicitly: > #6323 `rmqctl/cmd/catalog.go:372-373` discarded the results of the two `fmt.Fprintf(out, …)` calls that print the risk WARNING and the target prompt inside `defaultConfirm`, then went on to start the stdin reader goroutine — so when stderr could not be written, an L3 change such as `group reset-offset` still issued its preview and apply requests and exited 0 on a `yes` already sitting in the TTY buffer, without the operator ever being shown what was about to happen → both writes are checked and returned as `fmt.Errorf("write confirmation …: %w", err)` ahead of the answer read and the reader goroutine, normalised by the existing `normalizeCLIError`; `confirmRisk` (`:340-351`) still returns early for L1, `--dry-run` and `--yes`, so prompt-free paths are unchanged, and `docs/ai-agent-architecture.md:185-188` documents the behaviour in the L2/L3 two-step confirmation section. Closing as folded, not rejected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
