lizhimins opened a new pull request, #6346: URL: https://github.com/apache/rocketmq-dashboard/pull/6346
`com.h2database:h2` had no `<scope>`, so it defaulted to `compile` and `h2-2.4.240.jar` shipped inside the distributed fat JAR. H2 is dual-licensed MPL-2.0 / EPL-1.0 — ASF **Category B**, which needs legal review before it can go into a binary release. Nothing needs it in the artifact: - no source under `server/src/main` references H2 (only `application-dev.yml` names `org.h2.Driver`, and that is a dev-profile resource); - `deploy/docker-compose.yml:53` runs `SPRING_PROFILES_ACTIVE=prod` against MySQL; - the only consumers are the `dev` profile and the schema-migration tests under `server/src/test` (`CloudCredentialSchemaMigrationTest`, `AlertSchemaMigrationTest`, `AiConversationSchemaMigrationTest`, `SettingsWritePersistenceTest`, `ResourceOwnershipGuardTest`, ...), all of which get it from `test` scope. `mysql-connector-j` is already handled the same way for the opposite reason (GPL / Category X → `provided` + downloaded by the Dockerfile), and the pom comment right above it says as much. Verified: ``` $ mvn -B -ntp package -DskipTests -Dmaven.antrun.skip=true # antrun = binary-license-gate, tracked separately BOOT-INF/lib entries: 279 -> 278 h2 in BOOT-INF/lib: none $ mvn -B -ntp -T 8 test -Dspring.profiles.active=dev Tests run: 3523, Failures: 0, Errors: 0 ``` One flake worth recording rather than hiding: `ResourceOwnershipGuardTest.migrationConcurrentStartupIsIdempotentTest` errored once in the parallel run with `org.h2.jdbc.JdbcSQLNonTransientException: General error: "java.util.ConcurrentModificationException"` from `JdbcDatabaseMetaData.getIndexInfo`, and passes 33/33 in isolation — an H2 metadata race under `-T 8`, not a consequence of this change (the test classpath jar is byte-identical either way). **Behaviour change:** running the *packaged* JAR with `-Dspring.profiles.active=dev` now needs H2 supplied externally (`java -cp "app.jar:h2-2.4.240.jar" ...`), since `LOADER_PATH`/PropertiesLauncher already supports extra directories. `mvn test -Dspring.profiles.active=dev` is unaffected. This is recorded in the pom comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
