zmuxuny opened a new pull request, #6367:
URL: https://github.com/apache/rocketmq-dashboard/pull/6367

   ### Which Issue(s) This PR Fixes
   
   Fixes #6354.
   
   ### Brief Description
   
   Add Instance and one-click cloud import previously loaded only the first 20 
masked cloud-credential records. Credentials visible on later Settings 
inventory pages could never be selected.
   
   Read the existing bounded inventory pages before publishing the selector 
options. Follow the first response's total and page size, cap traversal at 100 
pages, deduplicate IDs, and stop after vendor changes or dialog dismissal. A 
failed later page does not publish a partial inventory as complete. No 
secret-reveal endpoint or credential permission changes.
   
   ### How Did You Test This Change?
   
   Base: rocketmq-studio@779b8c0e7aed2396d3cc72743dcd544ea48e9ae6. Linux, Node 
24.19.0, repository-pinned dependencies. Head: 
a5eb322bbfa7c2f8ec12e5599a41886a128c5db1.
   
   - Red/green: the same real InstancePage tests with coherent API pagination 
fail on unchanged production for 21 and 201 credentials; the 20-record control 
passes. All three pass with the fix. Selecting the later credential also checks 
the region lookup ID.
   - Related suites: 4 matched files, 55/55 tests pass, including 7 new 
InstancePage cases covering vendor change, dismissal, later-page failure and 
reopening. Ant Design virtualization is disabled in the page harness so loaded 
options can be inspected. The close case disables animation only because jsdom 
does not finish its exit motion.
   - npm run lint: exit 0, 0 errors, 10 pre-existing warnings in untouched 
sections.
   - npm run build: TypeScript, Vite and license gate pass.
   - Changed-file ESLint/Prettier, final TypeScript check and git diff --check 
pass.
   
   The full frontend suite and backend/Go tests were not run; no real cloud 
credential, broker, database or deployment was exercised. Remote CI is not yet 
claimed green.
   
   AI assistance was used for investigation, implementation and tests. A 
separate automated reviewer inspected the actual diff, paging contract and 
baseline red evidence; no human/maintainer approval is claimed.
   
   ### Checklist
   
   - [x] One coherent fix and meaningful regressions
   - [x] Conventional Commit subject; new test names end in Test
   - [x] Existing license headers retained; no new source files
   - [x] No new UI strings or API changes
   - [ ] Backend architecture/integration checks: not run for this 
frontend-only change
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to