zmuxuny opened a new pull request, #6382:
URL: https://github.com/apache/rocketmq-dashboard/pull/6382

   ### Which Issue(s) This PR Fixes
   
   Fixes #6374
   
   ### Brief Description
   
   The dashboard overview's error/loading branches omit MetricsExplorer, 
destroying an independent Prometheus investigation when only an overview read 
fails. Retrying recreates an empty editor and loses the selected source, time 
window, applied query, result and unsaved draft.
   
   Render the same keyed MetricsExplorer across overview states. Keep the key 
stable for the same selected instance and change it on instance switches or 
clearing selection, preserving existing cross-context cleanup.
   
   ### How Did You Test This Change?
   
   Base: rocketmq-studio at 779b8c0e7aed2396d3cc72743dcd544ea48e9ae6.
   
   - Real DashboardPage plus real MetricsExplorer integration tests; only 
separate service/API boundaries are mocked.
   - Original production: 2 target failures / 9 passing controls in the 
complete DashboardPage file. The failures are editor disappearance during 
overview error and an empty draft after retry.
   - Final DashboardPage + MetricsExplorer suites: 2 files / 50 tests passed. 
An independent reviewer reran all 50 successfully.
   - During overview failure, run another expression and verify 
queryByDataSource still uses Prometheus A, instance-a and 6h. After overview 
retry, preserve draft/source/range and verify Refresh All uses the applied 
query rather than accidentally submitting the draft.
   - Switching to instance-b or clearing selection resets the old session and 
issues no new query to the old named source. Existing overview stale-response 
controls remain green.
   - Full lint: 0 errors / 10 baseline warnings. Changed-file Prettier and diff 
check passed.
   - Full TypeScript/Vite production build and license check passed (133 
components / 140 files).
   - No live cluster, service or credentials. Full frontend suite/backend tests 
were not run locally; CI remains to be verified.
   
   ### Checklist
   
   - [x] One coherent change and Conventional Commit
   - [x] Real-component regressions and cross-instance controls added
   - [x] No new UI text, source files, dependencies, or configuration
   - [ ] Backend architecture checks (not run locally; frontend-only change)
   - [x] Existing overview error and retry guidance retained
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to