Loyal-Young opened a new pull request, #6422:
URL: https://github.com/apache/rocketmq-dashboard/pull/6422

   ### Which Issue(s) This PR Fixes
   
   Fixes #6414
   
   ### Brief Description
   
   When a recurring silence starts inside a spring DST gap, Java shifts that 
start forward. Computing the end from this already-adjusted start shifts the 
end too, suppressing notifications past the configured wall-clock boundary.
   
   Resolve the start and end independently from the scheduled local date/time. 
This retains the existing gap handling and preferred offsets for fall-back 
overlaps, while keeping an otherwise valid end at its configured time. An 
occurrence whose adjusted start is after its end has no active interval.
   
   ### How Did You Test This Change?
   
   Java 21, from `server`:
   
   - `mvn -B -ntp -Dtest=AlertSilenceScheduleTest test` before the fix: 4 new 
regression failures, 11 existing tests passed.
   - `mvn -B -ntp 
-Dtest=AlertSilenceScheduleTest,AlertSilenceServiceTest,ArchitectureTest test` 
after the fix: **27 tests passed**, Checkstyle passed. This snapshot has no 
`ArchitectureTest`; the executed suites were the two silence test classes.
   - `git diff --check`: passed.
   
   The regressions cover daily and weekly New York gaps, Lord Howe's 30-minute 
gap, an interval collapsed by the gap, and return to the ordinary schedule. 
Existing fall-back overlap and recurrence-limit tests remain green. No live 
notification delivery or database integration test was run.
   
   ### Checklist
   
   - [x] One coherent fix; Conventional Commit subject
   - [x] Regression tests added, methods end in `Test`
   - [x] No new UI strings or source files
   - [x] No module dependency changes
   - [x] Boundary-resolution behavior explained next to the calculation
   
   ### AI Assistance
   
   AI assistance was used to inspect the recurrence calculation, construct 
timezone regression cases, draft the patch, and execute local verification.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to