Loyal-Young opened a new pull request, #6461:
URL: https://github.com/apache/rocketmq-dashboard/pull/6461

   ### Which Issue(s) This PR Fixes
   
   Fixes #6453
   
   ### Brief Description
   
   Select `GOHOSTOS` / `GOHOSTARCH` for the native Windows build and optional 
test run. Previously inherited `GOOS=linux GOARCH=arm64` produced a Linux ARM64 
binary named `rmqctl.exe`, and `-RunTests` attempted to execute foreign test 
binaries.
   
   ### How Did You Test This Change?
   
   - Go 1.27.1 / PowerShell 7 on Windows: `go test ./scripts -run 
TestWindowsNativeBuild -count=1 -v`: passed.
   - The regression copies the real build script into an isolated minimal Go 
module in a path containing Chinese characters/spaces, sets Linux/ARM64 as 
inherited targets, invokes `-RunTests`, executes the built binary and verifies 
its native target and UTF-8 output. It also verifies the test run produced its 
marker.
   - Before the fix, the regression failed with `%1 is not a valid Win32 
application` while executing the generated test binary.
   - gofmt and `git diff --check`: passed.
   
   This test builds a minimal Go fixture, not the complete rmqctl application. 
PowerShell 5.1 and non-Windows hosts were not executed; the test skips on 
non-Windows hosts or when PowerShell is unavailable.
   
   ### Checklist
   
   - [x] One native-build fix and executable regression test
   - [x] ASF header on the new test
   - [x] No new dependency
   
   ### AI Assistance
   
   AI assistance was used to reproduce the inherited-target failure, implement 
the host-target selection and regression, and execute the checks above.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to