messere1 commented on PR #6145: URL: https://github.com/apache/rocketmq-dashboard/pull/6145#issuecomment-6129313562
Thanks @lizhimins for verifying the defect on both paths and for the careful read of the new tests! Fixed in 0b443e8e: the doc comment above `resetConnectionQuery` now enumerates "instance / topic / producer group" (`Producer.tsx:125-127`), so it matches the three call sites. Full suite re-run: `npx vitest run src/pages/studio/__tests__/Producer.test.tsx` 18/18 pass, eslint clean. Also noted on the sequencing heads-up: `Producer.tsx` and its test are touched by #6078, #6128 and #5406. If any of those lands first I'll rebase promptly — especially #5406, since it edits the same `Form` block. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
