zmuxuny opened a new pull request, #6380:
URL: https://github.com/apache/rocketmq-dashboard/pull/6380

   ### Which Issue(s) This PR Fixes
   
   Fixes #6361
   
   ### Brief Description
   
   When a cluster-filtered client connection request fails, the catch handler 
resets the filter to ALL. That state change immediately triggers another, 
broader request. If it succeeds, the original error disappears and the operator 
sees connections from other clusters instead of the failed selected scope.
   
   Keep the selected cluster on failure so the error remains visible and Retry 
requests the same scope. Explicit context changes retain their existing reset 
behavior.
   
   ### How Did You Test This Change?
   
   Base: rocketmq-studio at 779b8c0e7aed2396d3cc72743dcd544ea48e9ae6.
   
   - Added a real ClientsPage regression with a deferred filtered failure. It 
fails on original production because an unsolicited ALL request follows.
   - The test asserts no broad fallback, a visible failure with no misleading 
rows, then a successful Retry using the original ns-prod cluster.
   - `node node_modules/vitest/vitest.mjs run --maxWorkers=1 
src/pages/cluster/__tests__/clientsSearch.test.ts 
src/pages/cluster/__tests__/ClientsPage.test.tsx`: 2 files / 30 tests passed.
   - Independent review and independent focused regression rerun passed.
   - Full lint: 0 errors / 10 existing warnings. Changed-file Prettier and diff 
check passed.
   - TypeScript, Vite production build and license check passed (133 components 
/ 140 files).
   - Mock service responses only. Full frontend suite/backend tests were not 
run locally; CI remains to be verified.
   
   ### Checklist
   
   - [x] One coherent change and Conventional Commit
   - [x] Real-page regression added with Test suffix
   - [x] No new UI text, source files, dependencies, or configuration
   - [ ] Backend architecture checks (not run locally; frontend-only change)
   - [x] No documentation change needed for restoring scope-preserving retry
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to