Loyal-Young opened a new pull request, #6445:
URL: https://github.com/apache/rocketmq-dashboard/pull/6445

   ### Which Issue(s) This PR Fixes
   
   Fixes #6440
   
   ### Brief Description
   
   Use numeric equality for native alert `==` and `!=`. Double.compare 
distinguishes negative and positive zero, so `== -0.0` failed for a zero sample 
and `!= -0.0` fired incorrectly. This now agrees with the other comparison 
operators and the semantic fingerprint, which already normalizes zero signs.
   
   ### How Did You Test This Change?
   
   - Java 21 `mvn -B -ntp test 
-Dtest=AlertRuleEvaluatorTest,AlertStateMachineTest,NativeAlertProcessorTest`: 
**49 passed**, no failures/errors/skips.
   - Four signed-zero cases failed before the fix. They cover both sign orders 
and percentage threshold normalization. A separate control retains exact 
comparisons for equal and adjacent unequal finite values; no epsilon is 
introduced.
   - Maven Checkstyle: 0 violations; `git diff --check`: passed.
   
   No live broker/database integration or full Maven suite was run. There is no 
ArchitectureTest class in this snapshot, so no ArchUnit run is claimed.
   
   ### Checklist
   
   - [x] One coherent fix with regression tests ending in `Test`
   - [x] Conventional Commit subject; no new UI strings or source files
   
   ### AI Assistance
   
   AI assistance was used to compare evaluator and fingerprint semantics, draft 
the fix and regression cases, and execute the Java checks above.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to