123123213weqw opened a new pull request, #6391:
URL: https://github.com/apache/rocketmq-dashboard/pull/6391
@lizhimins This is the gap you named when closing #5815: a *missing* result
frame still falls through to `COMPLETED` at `AiRunExecutor.java:500`.
## What
`decide()`'s final return treats "no abort, nothing projected, no failure,
no error subtype" as success. For an agent-stream turn that means the provider
process closed without ever delivering a result frame — nothing was projected,
nothing errored with a frame of its own, and the run row still ended
`COMPLETED`: a turn with no answer presented as a successful one.
## The fix
`decide()` now distinguishes the two paths by engine: for a non-HTTP engine,
"no abort, nothing projected, no failure, and no result frame of any kind" is a
provider that went away mid-turn, and it returns `FAILED` / `PROVIDER_ERROR` /
`llm.provider.no_result` ("agent stream ended without a result frame"). HTTP
completion turns never carry a result frame at all — their fall-through is the
correct reading — and the existing http-engine test (`A completion turn has no
agent CLI…`) still asserts `COMPLETED` untouched.
## Test
- Red-first: `aStreamThatEndsWithoutAResultFrameMustNotCompleteTheRunTest` —
a zero-frame agent stream asserts `FAILED` / `PROVIDER_ERROR` /
`llm.provider.no_result` (previously `COMPLETED`).
- The admission test and the conversation-naming test drove zero-frame stubs
and asserted `COMPLETED` as a side effect; the admission test now asserts the
no-result failure explicitly, and the naming test scripts a success frame so
its recovery run is a genuinely healthy completion.
`AiRunServiceTest` is green on this branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
