chennaji9 opened a new pull request, #6660: URL: https://github.com/apache/rocketmq-dashboard/pull/6660
### Which Issue(s) This PR Fixes None — small self-contained fix found by inspection (no issue tracked). ### Brief Description `deploy/.env.example` and `deploy/README.md` document `PUBLIC_PORT` as the entrance port (`PUBLIC_PORT=8080` in the README example), and `deploy.sh` both defaults it and probes `http://$REMOTE_HOST:$PUBLIC_PORT/` — but `deploy/docker-compose.yml` hardcoded the web mapping to `"6789:80"`. A deployment configured with any other port listened on 6789 while the health check and the success banner pointed at the configured port. - The web port mapping now interpolates `${PUBLIC_PORT:-6789}:80`, matching the env file `deploy.sh` already passes to Compose (`docker compose --env-file .env`). The default stays 6789 for unchanged setups. ### How Did You Test This Change? Rendered the Compose configuration only (no containers started), from `deploy/`: - `docker compose --env-file <fixture with only REMOTE_HOST> -f docker-compose.yml config` → web `published: "6789"` (default preserved); - `docker compose --env-file <fixture with PUBLIC_PORT=8080> -f docker-compose.yml config` → web `published: "8080"` (documented configuration now applies); - the same 8080 fixture against the unfixed file still renders `published: "6789"` — the bug this PR removes. ### Checklist - [x] One coherent change; unrelated modifications are not bundled in - [x] Commit subject follows Conventional Commits (`fix:`) - [x] Tests added or updated for non-trivial changes (n/a — YAML interpolation verified by `compose config` renders; the repo has no deploy test harness) - [x] New UI text has both Chinese and English entries under `web/src/i18n/` (n/a — no UI change) - [x] Architecture constraints stay green (n/a — no Java change) - [x] New source files carry the ASF license header (n/a — no new source file) - [x] Documentation touched where behaviour changed (n/a — behaviour now matches what README/.env.example already document) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
