123123213weqw opened a new pull request, #6694:
URL: https://github.com/apache/rocketmq-dashboard/pull/6694

   Fixes #6411.
   
   `AssistantBubble` computed the run's terminal status but never passed it 
down, so `ToolBlock` derived `running` from `block.status` alone: a tool start 
whose run terminated without a result kept its Running tag, animated progress 
and "the tool is still running" output placeholder forever — while the bubble 
already showed Stopped/Failed, live and on replay of the persisted terminal run.
   
   `ToolBlock` now takes the run's terminal status. A start without a result on 
a `STOPPED`/`FAILED` run renders an honest missing-result state: a neutral `No 
result` tag, no spinner, and a note that the run terminated before the tool 
returned — with the tool arguments and any completed result preserved, and no 
invented success/failure outcome. Live rendering is unchanged (`runStatus` is 
null while the run streams).
   
   - `showsAnHonestMissingResultForAToolStartOrphanedByATerminatedRunTest` 
(STOPPED and FAILED): the orphaned card shows the `No result` tag, the progress 
line is gone and the note is present; the whole suite is 32/32.
   
   cc @lizhimins
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to