Loyal-Young opened a new pull request, #6703:
URL: https://github.com/apache/rocketmq-dashboard/pull/6703

   ## What is the purpose of the change
   
   Fixes #6702. The query history modal should retain whichever of its two 
independent reads succeeds. A summary error must not hide usable message or 
trace rows; a list error must not turn the known summary into zeros.
   
   ## Brief changelog
   
   - Load the summary and selected history page independently, so rows appear 
even while the summary is pending.
   - Show a targeted summary error with retry and use `-` for unknown counts.
   - Keep the list error and retry behavior for failed history pages.
   - Cover summary failure, list failure, and a still-pending summary in 
component tests.
   
   ## Verification
   
   - Before the fix: the two failure regressions failed (summary failure 
discarded rows; list failure displayed zero counts), and the deferred summary 
regression failed while the reads were joined.
   - After the fix: all 10 `MessageQueryHistoryModal` tests passed.
   - App TypeScript check, changed-file ESLint, and `git diff --check` passed.
   
   ## Related work
   
   #5790 addresses pagination when the scope shrinks. This PR handles 
independent request failures in the same modal; it does not alter pagination.
   
   ## AI assistance
   
   AI assistance helped trace the two request paths, draft the focused 
regressions, and review the result. I confirmed the regressions on the original 
implementation and ran the checks listed above.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to